Skip to content

Commit

Permalink
misc(proto): made default LighthouseError enum 'UNDEFINED' (#6334)
Browse files Browse the repository at this point in the history
  • Loading branch information
exterkamp authored and paulirish committed Oct 18, 2018
1 parent 3b33497 commit bb8248c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ lighthouse-extension/ @paulirish @patrickhulce
lighthouse-viewer/ @ebidel @brendankenny

docs/ @paulirish
proto/ @brendankenny @exterkamp

# no explicit owner for plots, travis, etc
2 changes: 1 addition & 1 deletion proto/lighthouse-result.proto
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import "google/protobuf/wrappers.proto";

// Canonical list of errors created by Lighthouse.
enum LighthouseError {
UNPARSEABLE_ERROR_CODE = 0;
UNDEFINED = 0;
// No error in Lighthouse; the results are reliable.
NO_ERROR = 1;
// An uncategorized error occurred, likely a JavaScript exception.
Expand Down

0 comments on commit bb8248c

Please sign in to comment.