Skip to content

Commit

Permalink
core(config): use abbreviation for pwa category title (#13270)
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark authored Nov 1, 2021
1 parent 7d4eeab commit bf2c15d
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion clients/extension/scripts/settings-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const DEFAULT_CATEGORIES = [{
title: 'SEO',
}, {
id: 'pwa',
title: 'Progressive Web App',
title: 'PWA',
}];

/** @typedef {{selectedCategories: string[], device: string}} Settings */
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1210,7 +1210,7 @@ Object {
"supportedModes": Array [
"navigation",
],
"title": "Progressive Web App",
"title": "PWA",
},
"seo": Object {
"auditRefs": Array [
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/config/default-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ const UIStrings = {
/** Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website accessible to search engine crawlers. */
seoCrawlingGroupDescription: 'To appear in search results, crawlers need access to your app.',
/** Title of the Progressive Web Application (PWA) category of audits. This is displayed at the top of a list of audits focused on topics related to whether or not a site is a progressive web app, e.g. responds offline, uses a service worker, is on https, etc. Also used as a label of a score gauge. */
pwaCategoryTitle: 'Progressive Web App',
pwaCategoryTitle: 'PWA',
/** Description of the Progressive Web Application (PWA) category. This is displayed at the top of a list of audits focused on topics related to whether or not a site is a progressive web app, e.g. responds offline, uses a service worker, is on https, etc. No character length limits. 'Learn More' becomes link text to additional documentation. */
pwaCategoryDescription: 'These checks validate the aspects of a Progressive Web App. ' +
'[Learn more](https://developers.google.com/web/progressive-web-apps/checklist).',
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/test/results/sample_v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -6767,7 +6767,7 @@
"score": 0.67
},
"pwa": {
"title": "Progressive Web App",
"title": "PWA",
"description": "These checks validate the aspects of a Progressive Web App. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist).",
"manualDescription": "These checks are required by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are not automatically checked by Lighthouse. They do not affect your score but it's important that you verify them manually.",
"supportedModes": [
Expand Down
2 changes: 1 addition & 1 deletion report/test/renderer/report-renderer-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe('ReportRenderer', () => {
const output = renderer.renderReport(sampleResultsCopy, container);

function isPWAGauge(el) {
return el.querySelector('.lh-gauge__label').textContent === 'Progressive Web App';
return el.querySelector('.lh-gauge__label').textContent === 'PWA';
}
function isPluginGauge(el) {
return el.querySelector('.lh-gauge__label').textContent === 'Some Plugin';
Expand Down
2 changes: 1 addition & 1 deletion shared/localization/locales/en-US.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/en-XL.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit bf2c15d

Please sign in to comment.