Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot find module printer #1101

Closed
paulirish opened this issue Dec 2, 2016 · 4 comments · Fixed by #1113
Closed

cannot find module printer #1101

paulirish opened this issue Dec 2, 2016 · 4 comments · Fixed by #1113

Comments

@paulirish
Copy link
Member

image

@wardpeet
Copy link
Collaborator

wardpeet commented Dec 2, 2016

Can't reproduce, i'm on latest master, did a new tsc build just to be sure and no error

@wardpeet wardpeet added the cli label Dec 2, 2016
@paulirish
Copy link
Member Author

I didn't do a tsc build, but I was expecting the helpful message of https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-cli/compiled-check.js to show up rather than this exception.

@wardpeet
Copy link
Collaborator

wardpeet commented Dec 3, 2016

i'll have a look :)

@wardpeet
Copy link
Collaborator

wardpeet commented Dec 5, 2016

I could reproduce this with the following case:
cd lighthouse-cli;npm run build;rm printer.js;cd ..;

now run lighthouse and you will see the error. The reason for this is that we only check if bin.js exists. require('./compiled-check.js')('bin.js'); We could do this check for each js file in the cli but not sure if this will happen to our users.

//edit
we could also check in the error listeners if a file is missing in the cli folder and assume that it's a tsc problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants