extra checks for printer.js existing. #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well it fixes the issue you posted but if chrome-launcher is missing we have the same issue. Why not add all ts files to the list? |
the check is already in place for chrome-launcher.
IMO its easier to maintain this list of bare minimum compiled files vs make sure all cli/*.ts-to-js files are in there always. |
|
chrome-launcher. is only checked when using manual-chrome-launcher.js not when ran by cli.js I don't mind if only printer is checked ;) |
wardpeet
approved these changes
Dec 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cheap fix, but I think we don't need anything more substantial.
fixes #1101