Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot redirect HTTP traffic to HTTPS #11455

Closed
GlenKPeterson opened this issue Sep 18, 2020 · 4 comments
Closed

Cannot redirect HTTP traffic to HTTPS #11455

GlenKPeterson opened this issue Sep 18, 2020 · 4 comments

Comments

@GlenKPeterson
Copy link

GlenKPeterson commented Sep 18, 2020

We don't allow HTTP traffic. Port 80/HTTP is closed at the firewall/router. Only port 443/HTTPS is open. How do I pass this test?

For reference, the production version of the site (not a PWA yet) is https://memoryjoggerlibrary.com/

I'm not sure, but it looks as if this error may prevent me from achieving any score at all for PWA. I just have a question-mark where the score would go.

@patrickhulce
Copy link
Collaborator

Thanks for filing @GlenKPeterson!

How do I pass this test?

You can't. The only real option to pass would be getting added to the HSTS preload list, but that's quite overkill and a long-term commitment to never serving content over HTTP across all subdomains.

I'm not sure, but it looks as if this error may prevent me from achieving any score at all for PWA. I just have a question-mark where the score would go.

That would be my expectation based on the way this domain handles the firewall rules. I would expect Lighthouse to always flag a connection timeout as an error that could not be computed even in a hypothetical future version of an audit that wanted to pass sites that rejected port 80 connections.

@GlenKPeterson
Copy link
Author

GlenKPeterson commented Sep 18, 2020

Thank you for your quick response!

Can I still make a progressive web app for this site without allowing HTTP traffic? I mean, does this Lighthouse test failure mean my site failed, or that Lighthouse just doesn't handle this situation?

I looked at the HSTS page - thank you for that. I'm not 100% ready to commit to HTTPS-only for a whole year. We're still in the rollout phase for this new application. We haven't had any HTTPS-related problems yet, but I want to wait longer before deciding that we won't have any.

@brendankenny
Copy link
Member

This audit was removed in #12643 (in the 9.0 release). There's a proposal to revive it in #13548, but it would no longer fail in this case (it only applies if the tested URL was http and didn't redirect to https, so wouldn't apply for test URLs that are https from the start), so I'm going to close this issue.

@GlenKPeterson
Copy link
Author

@brendankenny Sounds like a good solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants