-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove without-javascript audit #11459
Comments
Thanks for filing @GlenKPeterson! This is the same root issue as #11455. The without javascript test is the same page load as the HTTP redirect. |
For Lighthouse contributors, I propose just converting the without-javascript check to look for a |
That does mean e.g. example.com (and any other completely static site) would fail the audit :/ I would guess that those are more common than sites not serving something on Another option worth considering is retiring the |
Ditching entirely sounds promising as well :) |
We're going to delete the without-javascript audit for lighthouse v7 |
My home page does not require JavaScript (except to start the service worker) and looks fine with it disabled. I added a
<noscript>
element and can see its text display, but the test doesn't care (probably because it doesn't run).Provide the steps to reproduce
What is the current behavior?
Test doesn't even run.
What is the expected behavior?
Test runs and passes
Environment Information
Related issues
#11455 Failing this previous test may break some subsequent ones, IDK.
The text was updated successfully, but these errors were encountered: