Print the "invalid value" for output in CLI flags

[ha-douken]

FAQ

• Yes, my issue is not about variability or throttling.
• Yes, my issue is not about a specific accessibility audit (file with axe-core instead).

URL

https://www.google.com

What happened?

$ npx lighthouse --output=json --output=html https://www.google.com
throws
Invalid values. Argument 'output' must be an array from choices "json", "html", "csv"

node: v12.22.3
"lighthouse": "8.1.0"

What did you expect?

It to run.

What have you tried?

No response

How were you running Lighthouse?

CLI

Lighthouse Version

8.1.0

Chrome Version

No response

Node Version

12.22.3

Relevant log output

Invalid values. Argument 'output' must be an array from choices "json", "html", "csv"

[patrickhulce]

Thanks for filing @ha-douken! This is unfortunately, WAI. --output is flexible so it allows the use of spaces in between arguments. You need to run npx lighthouse https://www.google.com --output=json --output=html. As a rule, always put the URL first.

The error message could definitely be improved though, we'll add the unexpected value to the debug output.

[svkrclg]

Is this issue being picked up for dev? If not, would love to work on this. Any directions would be awesome @patrickhulce

[patrickhulce]

Go for it @svkrclg!

Basically in

lighthouse/lighthouse-cli/cli-flags.js

Lines 364 to 374 in 233c56e

	const outputTypes = ['json', 'html', 'csv'];
	const errorMsg = `Invalid values. Argument 'output' must be an array from choices "${outputTypes.join('", "')}"`;
	if (!values.every(/** @return {item is string} */ item => typeof item === 'string')) {
	throw new Error(errorMsg);
	}
	// Allow parsing of comma-separated values.
	const strings = values.flatMap(value => value.split(','));
	if (!strings.every(/** @return {str is LH.OutputMode} */ str => outputTypes.includes(str))) {
	throw new Error(errorMsg);
	}
	return strings;

you'll want to add the value that failed validation to our error message instead of just a generic one :)

[rohan-kulkarni-25]

Hey @patrickhulce Is this issue solved or needs any more help !! Please let me know I will be happy to do

[patrickhulce]

This has been solved by #12836, thanks @rohan-kulkarni-25!