-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(cli): improve error if invalid value for --output
argument is passed
#12836
misc(cli): improve error if invalid value for --output
argument is passed
#12836
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
--output
argument is passed
@googlebot I signed it! |
--output
argument is passed--output
argument is passed
lighthouse-cli/cli-flags.js
Outdated
const validValues = strings.filter(/** @return {str is LH.OutputMode} */ str => { | ||
if (!outputTypes.includes(str)) { | ||
throw new Error(`"${str}" is not a valid 'output' value. ` + errorHint); | ||
} return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
} return true; | |
} | |
return true; |
hey @adamraine how can I retrigger the failed checks? |
@svkrclg I restarted them for ya :) |
Thanks @patrickhulce . |
Yes we are currently struggling with many node and Chromium side bugs in our tests :/ don't worry about those definitely not your doing! we're trying to sort out those issues this week. |
Great, thanks @patrickhulce |
Summary
Improve
--output
error message for invalid values.Related Issues/PRs
#12787