Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bf-cache always fails in headless mode #14784

Closed
adamraine opened this issue Feb 10, 2023 · 3 comments · Fixed by #15577
Closed

bf-cache always fails in headless mode #14784

adamraine opened this issue Feb 10, 2023 · 3 comments · Fixed by #15577
Assignees

Comments

@adamraine
Copy link
Member

adamraine commented Feb 10, 2023

With --chrome-flags"--headless":
Screenshot 2023-02-10 at 9 02 53 AM

@dwsmart
Copy link

dwsmart commented Feb 22, 2023

Running in the new headless mode seems to fix this, so changing

const chrome = await chromeLauncher.launch({chromeFlags: ['--headless']});

to

const chrome = await chromeLauncher.launch({chromeFlags: ['--headless=new']});

Seems to solve the window.open() issue:
screenshot of lighthouse 10.0.1 test for https://example,com, using new headless mode

@adamraine
Copy link
Member Author

I doubt the old headless Chrome will every support bfcache testing, so we shouldn't consider this a bug. That being said, we should warn the user when the results are foobar and/or mark the audit as n/a.

@Yogurt4
Copy link

Yogurt4 commented Oct 28, 2023

That being said, we should warn the user when the results are foobar and/or mark the audit as n/a.

Agreed. Lighthouse gives me a "Page prevented back/forward cache restoration" fail. Testing it with Chrome DevTools gives "Successfully served from back/forward cache." though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants