-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RootCauses Artifact is slow if there are lots of "SVG changed" invalidations #15869
Comments
Definitely reproducible, looks like we are truing to get the node details of every layout invalidation node which is taking a while. |
Lighthouse issue: GoogleChrome/lighthouse#15869 Bug: None Change-Id: I72b2a0be71f7f45cb522fc710577fb78b38c7963 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5384002 Reviewed-by: Paul Irish <[email protected]> Reviewed-by: Connor Clark <[email protected]> Commit-Queue: Paul Irish <[email protected]>
For me Lighthouse takes ~4 minutes locally on https://lottiefiles.com/ We should continue to iterate on the performance of the root causes engine, but https://lottiefiles.com/ also contains a lot of invalidation tracking events (specifically iframe added to dom events) that the root causes engine has to sift through. We may want to limit the root causes engine somehow since it's results are helpful but not vital. |
Follow-up to: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5384002 Lighthouse issue: GoogleChrome/lighthouse#15869 Bug: None Change-Id: I61bfd87e85955421d667a01c38212d64d5cc7e77 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5405255 Reviewed-by: Paul Irish <[email protected]> Reviewed-by: Connor Clark <[email protected]> Commit-Queue: Adam Raine <[email protected]>
The iframe root cause check casts a very wide net for events that could have caused an iframe to be added. We are eventually going to drop the CDP requirement for root causes, so it isn't worth it to make the process more efficient. Follow-up to: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5384002 Lighthouse issue: GoogleChrome/lighthouse#15869 Bug: 331429737 Change-Id: I68d51ac6b3ed8910ef0b032f885608baf04594b9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5421436 Reviewed-by: Paul Irish <[email protected]> Commit-Queue: Adam Raine <[email protected]>
The performance should of It might be possible to improve performance further, but I expected us to overhaul the root causes engine in the near future so I think we can close this. |
FAQ
URL
https://lottiefiles.com/
What happened?
Run Lighthouse
lighthouse https://lottiefiles.com/
The root causes gatherer takes 34 seconds
Counting the invalidations/prepaints:
What did you expect?
I expected it to be faster.
What have you tried?
Some initial profiling on another lottie player site:
How were you running Lighthouse?
CLI
Lighthouse Version
11.6.0
Chrome Version
No response
Node Version
No response
OS
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: