Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong value in the type of "score" in the "Understanding result" documentation #8901

Closed
khalyomede opened this issue May 8, 2019 · 3 comments · Fixed by #9225
Closed

Wrong value in the type of "score" in the "Understanding result" documentation #8901

khalyomede opened this issue May 8, 2019 · 3 comments · Fixed by #9225

Comments

@khalyomede
Copy link

Explaination
I noticed your documentation is mentionning the score of one of the key report.lhr.categories.{}.score as String, but it appears in my console as Number.

Reproduce the issue

  1. Go to the documentation : https://github.com/GoogleChrome/lighthouse/blob/master/docs/understanding-results.md#categoryentry-properties
  2. See that the type of the score cell is String

Expected result
The documented type should be Number instead of String.

Note
I noticed it when I printed the score of the "performance" key for one of my lighthouse run for my website.

@patrickhulce
Copy link
Collaborator

Thanks @khalyomede! Interested in a PR? :)

@khalyomede
Copy link
Author

Sure @patrickhulce! On my way. :)

@kaushikchaubal
Copy link
Contributor

@khalyomede / @patrickhulce - i have created a PR for this. This is my first PR to this community so if anything looks wrong, please shout out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants