Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unchecked audits in Extension options leads to error #921

Closed
paulirish opened this issue Nov 7, 2016 · 4 comments · Fixed by #946 or #973
Closed

Unchecked audits in Extension options leads to error #921

paulirish opened this issue Nov 7, 2016 · 4 comments · Fixed by #946 or #973

Comments

@paulirish
Copy link
Member

I unchecked "Best Practices"
image

but at the end of the run, it failed with this message
image

Pretty sure this is coming from the new #914 so we'll need to adjust things to allow this usecase.

@wardpeet can you look at this?

@paulirish
Copy link
Member Author

Also let's treat this as a blocker for any new extension release.

@brendankenny
Copy link
Member

Yeah, this isn't completely fixed.

@brendankenny brendankenny reopened this Nov 18, 2016
@wardpeet
Copy link
Collaborator

wardpeet commented Nov 18, 2016

@brendankenny should I have a look?
@paulirish just reading this now (sorry)

@brendankenny
Copy link
Member

should I have a look?

I have a fix (needed to filter the aggregations in addition to the audits), but will wait for the morning to push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment