filter unneeded aggregations from config before extension runs #973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #921 (but for real this time)
The issue was that we were correctly filtering out audits from running based on what aggregation categories were selected in the extension, but we weren't filtering out the aggregations themselves. When report time comes along, the unselected aggregations were looking for results in audits that had been filtered out, causing the error.
@pavelfeldman: This needs to happen for both the extension and worker (DevTools) versions, though, which means it needs to happen in
lighthouse-background.js
. This means a (hopefully minor) breaking change for DevTools, as it will now need to pass in a set of aggregations to run, not a set of audits.