Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1069 - remove scores from perf metrics. Change to pass/fail. #1072

Merged
merged 1 commit into from
Nov 28, 2016
Merged

Fixes #1069 - remove scores from perf metrics. Change to pass/fail. #1072

merged 1 commit into from
Nov 28, 2016

Conversation

ebidel
Copy link
Contributor

@ebidel ebidel commented Nov 28, 2016

R: @brendankenny @paulirish @patrickhulce

Per #1069, this removes the scoring labels from the performance metrics section.

Notes:

  • The user timing metrics will always be a green checkbox.
  • For critical requests, if you have more than 0, you'll always get a red x. We don't have a good story there for what to display.

screen shot 2016-11-28 at 2 42 49 pm

@ebidel ebidel changed the title Fixes #1069 - remove score labels for perf metrics section Fixes #1069 - remove scores from perf metrics. Change to pass/fail. Nov 28, 2016
paulirish
paulirish approved these changes Nov 28, 2016
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@ebidel ebidel merged commit 3448105 into master Nov 28, 2016
@ebidel ebidel deleted the 1069 branch November 28, 2016 23:58
This was referenced Nov 30, 2016
Merged
Merged
andrewrota pushed a commit to andrewrota/lighthouse that referenced this pull request Jan 13, 2017
@ebidel @andrewrota
Fixes GoogleChrome#1069 - remove score labels for perf metrics section (
1de9888 
GoogleChrome#1072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebidel @paulirish