traceviewer-js files: drop whitespace & comments #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and FWIW this traceviewer submodule hash is 4959b8b832af4f0d91cf1b2bc9bed10fbcccad2e
paulirish
force-pushed
the
compacttraceviewer
branch
from
3f9886d
to
b9113ce
Compare
|
to be clear, this does not bump the traceviewer-js version, just shrinks the same version |
paulirish
added a commit
that referenced
this pull request
Dec 2, 2016
brendankenny
pushed a commit
that referenced
this pull request
Dec 2, 2016
andrewrota
pushed a commit
to andrewrota/lighthouse
that referenced
this pull request
Jan 13, 2017
…oogleChrome#1095) and FWIW this traceviewer submodule hash is 4959b8b832af4f0d91cf1b2bc9bed10fbcccad2e
andrewrota
pushed a commit
to andrewrota/lighthouse
that referenced
this pull request
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff looks big, but the only important one is in
lighthouse-core/scripts/build-traceviewer-module.jsWe want to keep the lighthouse-background.js filesize in check, and this reduces the footprint of traceviewer in it from 950kb to 551kb. Not bad.