Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(config): duplicated-javascript, legacy-javascript to default #11103

Merged
merged 1 commit into from
Jul 15, 2020
Merged

core(config): duplicated-javascript, legacy-javascript to default #11103

merged 1 commit into from
Jul 15, 2020
+163 −13

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jul 14, 2020 •
edited
Loading

ref #10369

@connorjclark connorjclark requested a review from a team as a code owner July 14, 2020 21:52
@connorjclark connorjclark requested review from patrickhulce and removed request for a team July 14, 2020 21:52
patrickhulce
patrickhulce reviewed Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

was there no tracking issue for these to reference or burndown to mark when we can move it to default?

code changes LGTM though :) 🎉

@connorjclark
Copy link
Collaborator Author

was there no tracking issue for these to reference or burndown to mark when we can move it to default?

#10369 i guess, but I decided to drop the "all at once" approach.

patrickhulce
patrickhulce approved these changes Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the key planned prereq issues seem to be addressed according to #10369 , we already started pulling in sourcemaps with 6.1.0 and these audits seem like they're ready for the early feedback.

let's do it! 🎉 :)

@patrickhulce patrickhulce merged commit c159869 into master Jul 15, 2020
@patrickhulce patrickhulce deleted the js-default branch July 15, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees

@patrickhulce patrickhulce

Labels
cla: yes waiting4committer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @patrickhulce @googlebot @devtools-bot