deps: update third-party-web #11137
Merged
deps: update third-party-web #11137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Beytoven I hope you don't mind trading reviews, @connorjclark specifically requested this so I thought I'd assign to him :) |
connorjclark
approved these changes
Jul 21, 2020
|
I'm sorry I could've sworn this was all green, I'm sorry everyone :( |
no worries.
but. i just made it one. :) |
Ahhhhhh, now it all makes sense 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates
third-party-webto 0.12.10.12.0 brought some nice goodies, including the breaking change of removing the examples entry from the
nostatsbundle we use (should shrink bundle size a tad). We could hypothetically remove the try/catch since it no longer has strict validation of a domain existing in the string, but we still pass in some totally non-URLs that could basic basic URL validation, so I'm inclined to leave ourgetEntityas-is.Related Issues/PRs
patrickhulce/third-party-web#106