Report: header sticks to top #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't look at this yet. Not ready. |
ebidel
changed the title
|
Ready |
ebidel
changed the title
paulirish
requested changes
Dec 8, 2016
| @@ -78,6 +82,11 @@ html, body { | |||
| height: 100%; | |||
| } | |||
|
|
|||
| /* When deep linking to a section, bump the headind down so it's not covered by the header. */ | |||
| background: #FFFFFF; | ||
| min-width: 185px; | ||
| /*min-width: 185px;*/ |
| display: flex; | ||
| flex-direction: row; | ||
| align-items: center; | ||
| justify-content: flex-end; | ||
| padding: 0 var(--heading-line-height); | ||
| position: fixed; | ||
| z-index: 1; |
There was a problem hiding this comment.
do me a solid and add will-change: transform on here as well? for lo-dpi chrome desktop users.
| .report-body__menu-container { | ||
| height: 100%; | ||
| width: 100%; | ||
| min-width: 230px; | ||
| max-width: 1280px; | ||
| max-width: var(--report-width); | ||
| position: fixed; |
There was a problem hiding this comment.
can u add will-change to this one as well?
There was a problem hiding this comment.
done.
I was curious about the layout of the app. It seems really funky to use pos fixed, transforms, and negative margins. What's up with that?
There was a problem hiding this comment.
the negative margins comes from @paullewis. tbh I've never used that technique and am not sure why we do it like that. :)
|
PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: all
This sticks the report header to the top of the page as you scroll. I think this is a nice change to make the share/print button always visible (e.g. LH viewer, devtools).