Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rimraf async for windows #1127

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Make rimraf async for windows #1127

merged 1 commit into from
Dec 8, 2016

Conversation

wardpeet
Copy link
Collaborator

@wardpeet wardpeet commented Dec 8, 2016

Should fix #1001 so far tmp files get deleted on my windows

brendankenny
brendankenny approved these changes Dec 8, 2016
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Hope second time is the charm :)

@brendankenny brendankenny merged commit a61c418 into GoogleChrome:master Dec 8, 2016
@brendankenny brendankenny mentioned this pull request Dec 8, 2016
Closed
andrewrota pushed a commit to andrewrota/lighthouse that referenced this pull request Jan 13, 2017
@wardpeet @andrewrota
Use async rimraf for Chrome temp profile deletion (GoogleChrome#1127)
c277fec
@wardpeet wardpeet deleted the windows-rimraf branch July 24, 2017 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lighthouse - rimraf - directory not empty exception
2 participants
@wardpeet @brendankenny