i18n: accept array of locales in lookupLocale #11349
Conversation
lighthouse-core/lib/i18n/i18n.js
Outdated
| * @param {string=} locale | ||
| * @return {LH.Locale} | ||
| * @return {LH.Locale|undefined} | ||
| */ | ||
| function lookupLocale(locale) { |
There was a problem hiding this comment.
paul suggested perhaps we should accept an array of locales here and do the "try the next value" in LH core.
connorjclark
changed the title
| it('falls back to root tag prefix if specific locale not available', () => { | ||
| expect(i18n.lookupLocale('en-JKJK')).toEqual('en'); | ||
| expect(i18n.lookupLocale('es-JKJK')).toEqual('es'); |
There was a problem hiding this comment.
test case was conflated with the default fallback behavior.
oooooh good catch. I tried to use this but it failed a test:
perhaps if edit: oh we just gave a too-narrow .d.ts. It works now! |
|
Wait, is there a bug in |
I think that's just our local d.ts declaration |
|
@connorjclark do you mind updating the docs to mention the array behavior? To clear up how prefix shortening and array order interact in precedence, for instance. |
ref https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2382176/comment/979304b7_ee2df92f/