report: set min-width on code table column #11359
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without an explicit width on this column with the potential for a large amount of content, there are some audit results that become unreadable.
patrickhulce
reviewed
Sep 1, 2020
patrickhulce
approved these changes
Sep 1, 2020
patrickhulce
changed the title
Beytoven
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without an explicit width on this column with the potential for a large amount of content, there are some audit results that become unreadable.
Summary
This is a bugfix, as the results from some audits become unreadable depending on the content. I noticed this when examining SEO results under the audit 'robots.txt is not valid'. Lighthouse version 6.0.0.
A width of 80% was chosen in this instance as it allows the 'Error' column to be read.Update: After feedback a
min-widthsolution of 100px is a much better fit.Before:
After:
Related Issues/PRs
None?