report: show overall category scores in csv output #11404

pujitha7 · 2020-09-10T15:44:50Z

closes #11398
Summary
Added one row each for category to show overall category score in the output CSV report

googlebot · 2020-09-10T15:46:34Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

pujitha7 · 2020-09-10T15:49:35Z

@googlebot I signed it!

googlebot · 2020-09-10T15:49:39Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-09-10T15:57:31Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

patrickhulce

thanks @pujitha7 this is great!

patrickhulce · 2020-09-10T16:19:41Z

lighthouse-core/report/report-generator.js

+      const overallCategoryScore = category.score === null ? -1 : category.score;
+      rows.push(rowFormatter([lhr.requestedUrl, lhr.finalUrl, category.title,
+        'overall-category-score', 'Overall Category Score', 'numeric', overallCategoryScore]));


WDYT about including the category in these column values? something like the below

Suggested change

const overallCategoryScore = category.score === null ? -1 : category.score;

rows.push(rowFormatter([lhr.requestedUrl, lhr.finalUrl, category.title,

'overall-category-score', 'Overall Category Score', 'numeric', overallCategoryScore]));

const table = Object.keys(lhr.categories).map(categoryId => {

const rows = [];

const category = lhr.categories[categoryId];

const overallCategoryScore = category.score === null ? -1 : category.score;

rows.push(rowFormatter([lhr.requestedUrl, lhr.finalUrl, category.title,

'${categoryId}-score', `${category.title} Category Score`, 'numeric', overallCategoryScore]));

Yeah it would be more readable. I will make these changes.

Oh, no we definitely don't need to iterate both. GitHub wouldn't allow a multi-line suggestion so this would absolutely replace the Object.values iteration (we pull in the value with const category = lhr.categories[categoryId]; here anyway).

Does that make sense?

Yeah it made sense a little later so deleted the comment. I modified the code. Please review

patrickhulce · 2020-09-10T16:21:15Z

lighthouse-core/test/report/report-generator-test.js

@@ -104,7 +104,7 @@ describe('ReportGenerator', () => {
      expect(lines.length).toBeGreaterThan(100);
      expect(lines.slice(0, 2).join('\n')).toMatchInlineSnapshot(`


let's use the first 3 lines now to test both category and audit lines?

patrickhulce

LGTM aside from the test fix, thanks @pujitha7!

patrickhulce · 2020-09-10T17:43:06Z

lighthouse-core/test/report/report-generator-test.js

+      csvOutput.includes('performance-score');
+      csvOutput.includes('accessibility-score');
+      csvOutput.includes('best-practices-score');
+      csvOutput.includes('seo-score');
+      csvOutput.includes('pwa-score');


Suggested change

csvOutput.includes('performance-score');

csvOutput.includes('accessibility-score');

csvOutput.includes('best-practices-score');

csvOutput.includes('seo-score');

csvOutput.includes('pwa-score');

expect(csvOutput).toContain('performance-score');

expect(csvOutput).toContain('accessibility-score');

expect(csvOutput).toContain('best-practices-score');

expect(csvOutput).toContain('seo-score');

expect(csvOutput).toContain('pwa-score');

currently it's not actually asserting :)

Oh yeah i missed that

patrickhulce · 2020-09-11T14:27:09Z

thanks @pujitha7! 🎉 great job here :)

pujitha7 requested a review from a team as a code owner September 10, 2020 15:44

pujitha7 requested review from brendankenny and removed request for a team September 10, 2020 15:44

devtools-bot assigned brendankenny Sep 10, 2020

devtools-bot added the waiting4reviewer label Sep 10, 2020

googlebot added the cla: no label Sep 10, 2020

vercel bot deployed to Preview September 10, 2020 15:46 View deployment

pujitha7 force-pushed the category-score-csv-report branch from 9f97082 to 0de16b2 Compare September 10, 2020 15:56

googlebot removed the cla: no label Sep 10, 2020

vercel bot deployed to Preview September 10, 2020 15:57 View deployment

googlebot added the cla: yes label Sep 10, 2020

patrickhulce suggested changes Sep 10, 2020

View reviewed changes

patrickhulce assigned patrickhulce and unassigned brendankenny Sep 10, 2020

patrickhulce added waiting4committer and removed waiting4reviewer labels Sep 10, 2020

vercel bot deployed to Preview September 10, 2020 17:10 View deployment

pujitha7 requested a review from patrickhulce September 10, 2020 17:36

patrickhulce suggested changes Sep 10, 2020

View reviewed changes

pujitha7 added 2 commits September 11, 2020 08:57

report: show overall category scores in csv output

dbe0331

report: add category names to column values

093bfab

pujitha7 force-pushed the category-score-csv-report branch from 1d6adb0 to be86c07 Compare September 11, 2020 03:29

vercel bot deployed to Preview September 11, 2020 03:29 View deployment

pujitha7 force-pushed the category-score-csv-report branch from be86c07 to 23c1209 Compare September 11, 2020 03:32

vercel bot deployed to Preview September 11, 2020 03:32 View deployment

report: fix test case

23d7519

pujitha7 force-pushed the category-score-csv-report branch from 23c1209 to 23d7519 Compare September 11, 2020 03:34

vercel bot deployed to Preview September 11, 2020 03:34 View deployment

pujitha7 requested a review from patrickhulce September 11, 2020 04:01

patrickhulce approved these changes Sep 11, 2020

View reviewed changes

patrickhulce merged commit a1571ba into GoogleChrome:master Sep 11, 2020

zhangpeidong-peyton pushed a commit to zhangpeidong-peyton/lighthouse that referenced this pull request Sep 14, 2020

report(csv): add overall category scores (GoogleChrome#11404)

ba2b4dc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

report: show overall category scores in csv output #11404

report: show overall category scores in csv output #11404

pujitha7 commented Sep 10, 2020 •

edited by patrickhulce

Loading

googlebot commented Sep 10, 2020

pujitha7 commented Sep 10, 2020

googlebot commented Sep 10, 2020

googlebot commented Sep 10, 2020

patrickhulce left a comment

patrickhulce Sep 10, 2020

pujitha7 Sep 10, 2020

patrickhulce Sep 10, 2020

pujitha7 Sep 10, 2020 •

edited

Loading

patrickhulce Sep 10, 2020

pujitha7 Sep 10, 2020

patrickhulce left a comment

patrickhulce Sep 10, 2020

patrickhulce Sep 10, 2020

pujitha7 Sep 11, 2020

patrickhulce commented Sep 11, 2020

		@@ -104,7 +104,7 @@ describe('ReportGenerator', () => {
		expect(lines.length).toBeGreaterThan(100);
		expect(lines.slice(0, 2).join('\n')).toMatchInlineSnapshot(`

report: show overall category scores in csv output #11404

report: show overall category scores in csv output #11404

Conversation

pujitha7 commented Sep 10, 2020 • edited by patrickhulce Loading

googlebot commented Sep 10, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

pujitha7 commented Sep 10, 2020

googlebot commented Sep 10, 2020

googlebot commented Sep 10, 2020

patrickhulce left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pujitha7 Sep 10, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patrickhulce left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patrickhulce commented Sep 11, 2020

pujitha7 commented Sep 10, 2020 •

edited by patrickhulce

Loading

pujitha7 Sep 10, 2020 •

edited

Loading