core(driver): don't clear indexedb, websql, or localstorage before run #11438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
requested review from
brendankenny
and removed request for
a team
I think a warning makes a lot of sense. Most people running into this in DevTools will likely be accidental (just trying out Lighthouse on their site) and not because they're trying out behavior of a warm load, so a warning on the report itself will be a good reminder of what they should do for an honest assessment of performance. OTOH, there won't be a way to get rid of the warning if you are doing it on purpose and we'll may have to revisit for Fraggle Rock. Any other opinions? |
|
How about the toplevel warning only gets added when |
connorjclark
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #772
Prevents loss of important data in any of indexeddb, websql, or localstorage. DevTools panel should display a warning to use an incognito window when there is data in these resources rather than clearing them.
In addition to DevTools warning, should we add a toplevel warning in the report if there was data in these resources?