Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: run every smoke test (except forms) for bundle #11493

Merged
merged 6 commits into from
Oct 2, 2020
Merged

tests: run every smoke test (except forms) for bundle #11493

merged 6 commits into from
Oct 2, 2020

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark requested a review from a team as a code owner September 29, 2020 21:28
@connorjclark connorjclark requested review from paulirish and removed request for a team September 29, 2020 21:28
@patrickhulce
Copy link
Collaborator

should we split this out so basics isn't all smokes plus the basics?

@connorjclark connorjclark changed the title tests: run every smoke test for bundle tests: run every smoke test (except forms) for bundle Oct 1, 2020
@connorjclark connorjclark changed the title tests: run every smoke test (except forms) for bundle tests: run every smoke test for bundle Oct 1, 2020
patrickhulce
patrickhulce approved these changes Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect thanks @connorjclark!

@patrickhulce
Copy link
Collaborator

(though one is failing)

@connorjclark
Copy link
Collaborator Author

The forms failure makes no sense ... banging my head against the wall on this one :/

@connorjclark
Copy link
Collaborator Author

connorjclark commented Oct 2, 2020 •
edited
Loading

Whatever it is, that audit is in experimental, and may receive a refactor that will remove the issue here, so I'm just going to exclude forms from the bundle test for now.

@connorjclark connorjclark changed the title tests: run every smoke test for bundle tests: run every smoke test (except forms) for bundle Oct 2, 2020
@connorjclark connorjclark merged commit 6a75241 into master Oct 2, 2020
@connorjclark connorjclark deleted the bundle-smoke branch October 2, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees

@paulirish paulirish

Labels
cla: yes waiting4committer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@connorjclark @patrickhulce @paulirish @googlebot @devtools-bot