-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump axe-core, as it's now 8x faster #1155
Conversation
cc @robdodson |
⏩ 💨 |
nice! |
Just started reviewing :) |
travis is sloooowly catching up |
LGTM. Just tested it against 1156 and everything works. I can rebase 1156 if you guys would like to merge this in first |
needs rebase/merge for yarn.lock |
hmm, why is yarn.lock getting changed so extensively? axe-core still has no dependencies of its own...just reorganizing the same entries in a different order? |
my mistake. I reran a fresh install and it was adding newest matching versions of all our deps. fixed now. |
Ah, I think that's what I've been doing...testing different modules for the viewer and started fresh sometimes. |
Big win if you've ever seen the "Retrieving: Accessibility..." message for longer than you'd expect.
Fixes #630
Over in dequelabs/axe-core#240 we reported some perf issues to the axe-core team. They've now addressed them and shipped the latest version of the library.
There were pages like Promise | MDN that took A LOT of time.
Death to forced layouts. 😀
Also, another win I didn't expect. The awesome team at @dequelabs also changed the runtime so that it yields to the main thread on nearly every tick of its auditing engine, which leads to a much more responsive experience: