Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump axe-core, as it's now 8x faster #1155

Merged
merged 1 commit into from
Dec 14, 2016
Merged

bump axe-core, as it's now 8x faster #1155

merged 1 commit into from
Dec 14, 2016

Conversation

paulirish
Copy link
Member

Big win if you've ever seen the "Retrieving: Accessibility..." message for longer than you'd expect.

Fixes #630

Over in dequelabs/axe-core#240 we reported some perf issues to the axe-core team. They've now addressed them and shipped the latest version of the library.

There were pages like Promise | MDN that took A LOT of time.

  • Before: 9.6 seconds
  • After: 1.1 seconds

Death to forced layouts. 😀


Also, another win I didn't expect. The awesome team at @dequelabs also changed the runtime so that it yields to the main thread on nearly every tick of its auditing engine, which leads to a much more responsive experience:

image

@paulirish
Copy link
Member Author

cc @robdodson

@ebidel
Copy link
Contributor

ebidel commented Dec 13, 2016

⏩ 💨

@robdodson
Copy link
Contributor

nice!

@robdodson
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@brendankenny
Copy link
Member

travis is sloooowly catching up

@robdodson
Copy link
Contributor

LGTM. Just tested it against 1156 and everything works. I can rebase 1156 if you guys would like to merge this in first

@brendankenny
Copy link
Member

needs rebase/merge for yarn.lock

@brendankenny
Copy link
Member

brendankenny commented Dec 14, 2016

hmm, why is yarn.lock getting changed so extensively? axe-core still has no dependencies of its own...just reorganizing the same entries in a different order?

@paulirish
Copy link
Member Author

hmm, why is yarn.lock getting changed so extensively? axe-core still has no dependencies of its own...just reorganizing the same entries in a different order?

my mistake. I reran a fresh install and it was adding newest matching versions of all our deps.

fixed now.

@ebidel
Copy link
Contributor

ebidel commented Dec 14, 2016

Ah, I think that's what I've been doing...testing different modules for the viewer and started fresh sometimes.

@brendankenny brendankenny merged commit 83a5fdb into master Dec 14, 2016
@brendankenny brendankenny deleted the bumpaxe branch December 14, 2016 02:09
andrewrota pushed a commit to andrewrota/lighthouse that referenced this pull request Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants