Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(dom-size): remove formatNumber #11563

Merged
merged 4 commits into from
Oct 14, 2020
Merged

core(dom-size): remove formatNumber #11563

merged 4 commits into from
Oct 14, 2020

Conversation

adamraine
Copy link
Member

Fixes #11562

@adamraine adamraine requested a review from a team as a code owner October 14, 2020 18:08
@adamraine adamraine requested review from Beytoven and removed request for a team October 14, 2020 18:08
@google-cla google-cla bot added the cla: yes label Oct 14, 2020
Beytoven
Beytoven approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@Beytoven Beytoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connorjclark
Copy link
Collaborator

breaking change enough to hold for v7?

@patrickhulce
Copy link
Collaborator

breaking change enough to hold for v7?

IMO, we don't need to. These were more of a bug fix (they were announced as numeric type in the headings but then row values weren't actually numeric) and the change is buried in details. I wouldn't expect this to be fatal or materially affect most clients.

@adamraine adamraine merged commit 6310655 into master Oct 14, 2020
@adamraine adamraine deleted the dom-size-number branch October 14, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark left review comments

@Beytoven Beytoven Beytoven approved these changes

Assignees

@Beytoven Beytoven

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Avoids an excessive DOM size" audit shows NaN when it exceeds 1000
5 participants
@adamraine @connorjclark @patrickhulce @Beytoven @devtools-bot