update eslint version for extension to match core #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yarn.lock? |
|
https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-viewer/package.json also needs updating. update viewer package in #1160 |
make extension linting failures fail build as well
ebidel
approved these changes
Dec 14, 2016
andrewrota
pushed a commit
to andrewrota/lighthouse
that referenced
this pull request
Jan 13, 2017
make extension linting failures fail build as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint for the project was updated in #1136, but the extension uses
gulp-eslintwhich also needed to be updated to understand some of the new linting rules (expliciteslint-config-xoalso no longer necessary aftereslint-config-googleupdates).npm run buildin the extension now fails if linting fails so that we notice the failures on Travis.