Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: fix npm auth in nightly release #11810

Merged
merged 10 commits into from
Dec 10, 2020
Merged

misc: fix npm auth in nightly release #11810

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eb09581
lol
connorjclark Dec 10, 2020
247cf27
test
connorjclark Dec 10, 2020
f674d6f
hmm
connorjclark Dec 10, 2020
da4cda0
hmm
connorjclark Dec 10, 2020
e2b71ba
hm
connorjclark Dec 10, 2020
e312dbe
hmm
connorjclark Dec 10, 2020
59eba0a
hm
connorjclark Dec 10, 2020
d073206
hm
connorjclark Dec 10, 2020
e16779f
okdood
connorjclark Dec 10, 2020
53d18cc
Merge remote-tracking branch 'origin/master' into nightly3
connorjclark Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,14 @@ jobs:
- uses: actions/setup-node@v1
with:
node-version: 12.x
registry-url: https://registry.npmjs.org/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the line that fixes it? The rest seems like it would have no effect except logging

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup. it writes a .npmrc ... which npm uses to know where to make requests to.... so dum

- run: yarn --frozen-lockfile

- run: bash $GITHUB_WORKSPACE/.github/scripts/bump-nightly-version.sh
- run: npm publish --tag next
- name: Publish to npm
run: |
npm whoami
bash $GITHUB_WORKSPACE/.github/scripts/bump-nightly-version.sh
npm publish --tag next
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
CI: true