Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(font-size): handle valueless attributes for inline styles #11934

Merged
merged 5 commits into from
Jan 19, 2021

Conversation

tkindy
Copy link
Contributor

@tkindy tkindy commented Jan 9, 2021

Summary

This PR fixes the bug described in #11606. A description of the root cause is in this comment.

Related Issues/PRs

Closes #11606

@tkindy tkindy requested a review from a team as a code owner January 9, 2021 20:33
@tkindy tkindy requested review from connorjclark and removed request for a team January 9, 2021 20:33
@google-cla

This comment has been minimized.

@google-cla google-cla bot added the cla: no label Jan 9, 2021
@tkindy
Copy link
Contributor Author

tkindy commented Jan 9, 2021

@googlebot I signed it!

Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@connorjclark connorjclark changed the title core(font-size): handle valueless attributes for inline style selectors core(font-size): handle valueless attributes for inline styles Jan 19, 2021
@connorjclark connorjclark merged commit 548dad3 into GoogleChrome:master Jan 19, 2021
@tkindy tkindy deleted the font-size-value-undefined branch January 19, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'trim' of undefined
4 participants