core(fr): add more gatherers to config #12016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| artifacts: ['Accessibility', 'ConsoleMessages'], | ||
| artifacts: [ | ||
| 'Accessibility', | ||
| 'Appcache', |
There was a problem hiding this comment.
they need to be defined in artifacts too, once that happens, the snapshot assertion for number of audits we compute should fail :)
There was a problem hiding this comment.
ah ok.
btw i found this vscode plugin, super useful https://marketplace.visualstudio.com/items?itemName=wmaurer.change-case
| @@ -89,7 +89,7 @@ describe('Fraggle Rock API', () => { | |||
|
|
|||
| const {auditResults, erroredAudits, failedAudits} = getAuditsBreakdown(lhr); | |||
| // TODO(FR-COMPAT): This assertion can be removed when full compatibility is reached. | |||
| expect(auditResults.length).toMatchInlineSnapshot(`58`); | |||
| expect(auditResults.length).toMatchInlineSnapshot(`65`); | |||
patrickhulce
approved these changes
Jan 28, 2021
|
this has been failing annoyingly often lately :/ I wonder if there's anything we can do |
adamraine
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forgot this in #11993
ref #11313