Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(image-elements): set 5s time budget, add _privateCssSizing #12065

Merged
merged 25 commits into from
Feb 11, 2021
Merged

core(image-elements): set 5s time budget, add _privateCssSizing #12065

merged 25 commits into from
Feb 11, 2021

Commits on Feb 5, 2021

  1. core(image-elements): speed up by only fetching CSS rules for largest… 

    … 50 images
    @paulirish
    paulirish committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    f6f8069 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. create a time budget

    @paulirish
    paulirish committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    7c6f6ea View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Update lighthouse-core/gather/gatherers/image-elements.js 

    Co-authored-by: Connor Clark <[email protected]>
    @paulirish @connorjclark
    paulirish and connorjclark authored Feb 10, 2021
    Configuration menu
    Copy the full SHA
    f94f851 View commit details
    Browse the repository at this point in the history

  2. comment and rename from feedback

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    a6b5ec2 View commit details
    Browse the repository at this point in the history

  3. invert name and check once

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    b07eb63 View commit details
    Browse the repository at this point in the history

  4. add log message on reachedGatheringBudget

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    6e00733 View commit details
    Browse the repository at this point in the history

  5. return null

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    6908ee2 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into fasterimageelments

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    449f39b View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/master' into fasterimageelments

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    689c1c1 View commit details
    Browse the repository at this point in the history

  8. rename these audit methods. its not about VALIDITY but SIZEDEDNESS

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    8e411dd View commit details
    Browse the repository at this point in the history

  9. handle the data-not-gathered case

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    0fbc7d4 View commit details
    Browse the repository at this point in the history

  10. cssWidth/height as empty string never made sense. previously it was u… 

    …ndefined. but anyway now its explicitly null. yay
    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    6bfb5ea View commit details
    Browse the repository at this point in the history

  11. 3s => 5s. lint.

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    37663b4 View commit details
    Browse the repository at this point in the history

  12. a cssSizing object. keep cssWidth/height the same for now

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    9bc2c89 View commit details
    Browse the repository at this point in the history

  13. 5s

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    fea8885 View commit details
    Browse the repository at this point in the history

  14. yarn update:sample-artifacts ImageElements plus v minor handtweaks

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    dc7f4a0 View commit details
    Browse the repository at this point in the history

  15. Apply suggestions from code review 

    Co-authored-by: Connor Clark <[email protected]>
    @paulirish @connorjclark
    paulirish and connorjclark authored Feb 10, 2021
    Configuration menu
    Copy the full SHA
    b80096c View commit details
    Browse the repository at this point in the history

  16. lint

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    7d80b31 View commit details
    Browse the repository at this point in the history

  17. rename to _privateCssSizing

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    99b3d4a View commit details
    Browse the repository at this point in the history

  18. set as optional. thx brendan

    @paulirish
    paulirish committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    8503001 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Update lighthouse-core/gather/gatherers/image-elements.js 

    Co-authored-by: Brendan Kenny <[email protected]>
    @paulirish @brendankenny
    paulirish and brendankenny authored Feb 11, 2021
    Configuration menu
    Copy the full SHA
    7e26ae2 View commit details
    Browse the repository at this point in the history

  2. remove unncessary return value from fetchElementWithSizeInformation()

    @paulirish
    paulirish committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    b19a8d3 View commit details
    Browse the repository at this point in the history

  3. adjust type definitions, based on brendan's feedback

    @paulirish
    paulirish committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    3a5eea3 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into fasterimageelments

    @paulirish
    paulirish committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    df4eb47 View commit details
    Browse the repository at this point in the history

  5. drop @deprecated per connor

    @paulirish
    paulirish committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    36b31f3 View commit details
    Browse the repository at this point in the history