Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks to @davidlehn's work with jsonld@5, this drops a number of our shipped npm dependencies, most importantly
request
. That's about 4 MiB savings innode_modules
when a project uses Lighthouse, and two fewer warnings onyarn add lighthouse
(which were for the deprecatedrequest
andrequest > har-validator
).Thanks also to @takenspc for pointing out the available jsonld savings in #12305.
Also a drive-by removal of
coveralls
which we still included as a devDep.request
remains a devDep for us due to our two dev versions ofjsdom
, but that's on their radar (but it's difficult): jsdom/jsdom#2792also ref: #8328 #12324