Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(deprecations): ignore warning for ::-webkit-details-marker #12341

Merged
merged 10 commits into from
Apr 13, 2021
Merged

core(deprecations): ignore warning for ::-webkit-details-marker #12341

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
18778d8
Temporary ignore deprecation on ::-webkit-details-marker
milutin Apr 8, 2021
8b72391
Fix lint
milutin Apr 8, 2021
59afc13
Add Todo
milutin Apr 9, 2021
dfe21b0
retrigger checks
milutin Apr 9, 2021
abeb65d
retrigger checks
milutin Apr 9, 2021
c47d044
retrigger checks - Third times a Charm
milutin Apr 9, 2021
e5a6cd8
retrigger checks - new day new try
milutin Apr 10, 2021
f928af7
retrigger checks - another day another try
milutin Apr 11, 2021
ac44492
retrigger checks
milutin Apr 13, 2021
82d763c
retrigger checks - one more try
milutin Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lighthouse-core/audits/deprecations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ class Deprecations extends Audit {
static audit(artifacts) {
const entries = artifacts.ConsoleMessages;

const deprecations = entries.filter(log => log.source === 'deprecation').map(log => {
const deprecations = entries.filter(log => log.source === 'deprecation')
// TODO(M91): Temporary ignore until Chrome M91 became stable version.
// M91 doesn't throw deprecation on ::-webkit-details-marker.
.filter(log => !log.text.includes('::-webkit-details-marker'))
.map(log => {
return {
value: log.text,
source: Audit.makeSourceLocationFromConsoleMessage(log),
Expand Down