tests(smoke): remove html imports from dbw_tester #12354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
Still a couple references to dbw_partial_*.html in the devtools logs and traces of lighthouse-core/test/results/artifacts but I don't think it's worth messing with those files.
We also might be in a deadlock with #12353. @paulirish can we force merge?
yeah, I didn't want to mess with those just because we'd have a lot more audit changes that weren't relevant for this change (just removing two network requests), but we will have to pull the trigger on those at some point, I suppose. |
brendankenny
force-pushed
the
htmlimports
branch
from
e502aa2
to
1df56fd
Compare
|
rebased on top of #12353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unblocks CI along with #12353
html imports have been deprecated for a loooong time (Chrome 70), but looks like they were only finally removed in Chrome 92.
dbw_tester has been holding on to them as render blocking resources, so it's time to remove since they no longer trigger a network request. Other render-blocking stuff is pretty well covered and I didn't see anything new to add in their place, so this is just a simple removal.