core(unsized-images): pass with explicit aspect-ratio #12377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const htmlWidthIsExplicit = UnsizedImages.doesHtmlAttrProvideExplicitSize(attrWidth); | ||
| const cssWidthIsExplicit = UnsizedImages.doesCssPropProvideExplicitSize(cssWidth); | ||
| const htmlHeightIsExplicit = UnsizedImages.doesHtmlAttrProvideExplicitSize(attrHeight); | ||
| const cssHeightIsExplicit = UnsizedImages.doesCssPropProvideExplicitSize(cssHeight); | ||
| const explicitAspectRatio = UnsizedImages.doesCssPropProvideExplicitSize(cssAspectRatio); |
There was a problem hiding this comment.
rename this method? I was expecting a check for numbers or size markers, forgetting that all we care about is !== 'auto' :)
now that we're using it for things that aren't just size, perhaps something more generic like isCssPropExplicitlySet?
There was a problem hiding this comment.
actually come to think of it we should probably be banning initial/unset/inherit too, do those come through on the protocol?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12218
We consider the image "sized" (thus passing) if
aspect-ratiois used in conjunction with either a width or a height:lighthouse/core/audits/unsized-images.js
Lines 99 to 100 in f212b1f