Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(smoke): verify CSP violations caused by lighthouse #12391

Merged
merged 9 commits into from
Apr 28, 2021
Merged

tests(smoke): verify CSP violations caused by lighthouse #12391

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
295ecca
start
adamraine Apr 20, 2021
5a92355
add source map
adamraine Apr 21, 2021
b0119bd
comments
adamraine Apr 21, 2021
b66a2d9
wow nice one adam
adamraine Apr 21, 2021
400b1b2
license
adamraine Apr 22, 2021
725cbf0
hash
adamraine Apr 22, 2021
a443ef6
instructions
adamraine Apr 22, 2021
56d51e3
Merge branch 'master' into csp-smoke
adamraine Apr 28, 2021
64d3ef6
fixed source map
adamraine Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lighthouse-cli/test/fixtures/csp.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
<!--
* Copyright 2021 The Lighthouse Authors. All Rights Reserved.
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
-->
<html>
adamraine marked this conversation as resolved.
Show resolved Hide resolved
<head>
<script>
Expand Down
3 changes: 2 additions & 1 deletion lighthouse-cli/test/smokehouse/test-definitions/csp/csp-expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ function headersParam(headers) {
return new URLSearchParams([['extra_header', headerString]]).toString();
}

// Only allow the empty script with the source map.
const blockAllExceptInlineScriptCsp = headersParam([[
'Content-Security-Policy',
'default-src \'none\'; script-src \'unsafe-inline\'',
`default-src 'none'; script-src 'sha256-qZLV55/xxILbIrha9pgX0OdkZMhOlaIgfpEo/6Dly2U='`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide instructions on how to generate this hash. Or, generate it dynamically based on csp.html.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added instructions. We could also use a hardcoded "nonce" for this test case.

]]);

/**
Expand Down