Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(cli): destructure args in import #12398

Merged
merged 3 commits into from
May 12, 2021
Merged

misc(cli): destructure args in import #12398

merged 3 commits into from
May 12, 2021

Conversation

evenstensberg
Copy link
Contributor

Summary
Refactoring

Refactored to destructuring to make it look better

Related Issues/PRs
N/A

@evenstensberg evenstensberg requested a review from a team as a code owner April 23, 2021 13:13
@evenstensberg evenstensberg requested review from connorjclark and removed request for a team April 23, 2021 13:13
@google-cla google-cla bot added the cla: yes label Apr 23, 2021
@evenstensberg evenstensberg reopened this Apr 23, 2021
@evenstensberg
Copy link
Contributor Author

Can't get PR lint to cooperate

@adamraine adamraine changed the title enh(destructuring): destructure args in import misc(cli): destructure args in import Apr 23, 2021
@adamraine
Copy link
Member

You can run yarn lint --fix to take care of the linter errors.

@google-cla
Copy link

google-cla bot commented May 12, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels May 12, 2021
@patrickhulce
Copy link
Collaborator

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels May 12, 2021
@patrickhulce patrickhulce merged commit 6fe4dd6 into GoogleChrome:master May 12, 2021
paulirish pushed a commit that referenced this pull request May 13, 2021
@evenstensberg @paulirish
misc(cli): destructure args in import (#12398)
56ed9ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

@connorjclark connorjclark Awaiting requested review from connorjclark

Assignees

@connorjclark connorjclark

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evenstensberg @adamraine @patrickhulce @connorjclark @devtools-bot