Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(script-treemap-data): include unmapped bytes #12452

Merged
merged 4 commits into from
May 11, 2021

Conversation

connorjclark
Copy link
Collaborator

Fixes issue mentioned in #11271 (comment)

ref #11254

@connorjclark connorjclark requested a review from a team as a code owner May 7, 2021 03:16
@connorjclark connorjclark requested review from adamraine and removed request for a team May 7, 2021 03:16
@google-cla google-cla bot added the cla: yes label May 7, 2021
@adamraine
Copy link
Member

Does http://localhost:8000/treemap/?debug have any unmapped bytes?

@connorjclark
Copy link
Collaborator Author

Just updated debug.json so it's there now. The nodes are too small to show in the treemap. Would be visible in the table though.

@connorjclark connorjclark merged commit ae57fac into master May 11, 2021
@connorjclark connorjclark deleted the script-treemap-data-unmapped branch May 11, 2021 00:44
@connorjclark connorjclark mentioned this pull request May 14, 2021
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants