core(fr): convert source-maps gatherer #12467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
May 11, 2021
patrickhulce
approved these changes
May 11, 2021
| async startSensitiveInstrumentation(context) { | ||
| const session = context.driver.defaultSession; | ||
| session.on('Debugger.scriptParsed', this.onScriptParsed); | ||
| await session.sendCommand('Debugger.enable'); |
There was a problem hiding this comment.
long-term WDYT about splitting out the script parsed bit as a dependency of this and JsUsage? (I think we took a similar note when we did JsUsage)
There was a problem hiding this comment.
Yeah that makes sense. This might be necessary if we want to run these gatherers in snapshot mode. If the events are sent after Debugger.enable, I'm not sure if we can get a set of events for each gatherer.
There was a problem hiding this comment.
I'm not sure if we can get a set of events for each gatherer.
We'll need the dedicated session creation piece of #11313 for that to work, but we'll be making it work :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #11313