Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: import new strings #12492

Merged
merged 1 commit into from
May 17, 2021
Merged

i18n: import new strings #12492

merged 1 commit into from
May 17, 2021

Conversation

brendankenny
Copy link
Member

mostly getting back the moved There may be stored data affecting loading performance... warning and a translated "View Treemap" button

@brendankenny brendankenny requested a review from a team as a code owner May 17, 2021 17:39
@brendankenny brendankenny requested review from patrickhulce and removed request for a team May 17, 2021 17:39
@google-cla google-cla bot added the cla: yes label May 17, 2021
@connorjclark
Copy link
Collaborator

I'm also going to do an import later this evening just before release, to get any last minute strings, FWIW.

@@ -1080,13 +1080,13 @@
"message": "Der Messwert \"Erster CPU-Leerlauf\" gibt an, wann die Aktivität des Hauptthreads der Seite das erste Mal gering genug ist, um Eingaben zu verarbeiten. [Weitere Informationen.](https://web.dev/first-cpu-idle/)"
},
"lighthouse-core/audits/metrics/first-meaningful-paint.js | description": {
"message": "\"Inhalte weitgehend gezeichnet\" gibt an, wann die Hauptinhalte einer Seite sichtbar sind. [Weitere Informationen.](https://web.dev/first-meaningful-paint/)"
"message": "\"First Meaningful Paint\" gibt an, wann die Hauptinhalte einer Seite sichtbar sind. [Weitere Informationen.](https://web.dev/first-meaningful-paint/)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, thank goodness we're perfecting our FMP strings in time for I/O 2021 😆

@brendankenny
Copy link
Member Author

I'm also going to do an import later this evening just before release, to get any last minute strings, FWIW.

Just trying to avoid pipeline stalls. I can leave this open and run it again this afternoon on the off chance that a locale or two has a new string.

@connorjclark
Copy link
Collaborator

sgtm, Thanks for the assist!

@brendankenny
Copy link
Member Author

re-ran after the tc dump and there aren't any new strings (basically waiting on the lighthouse-treemap/* translations from #12441 and the moved page load warnings from #12469, but those landed on Friday and today, so were unlikely to come through yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants