core(fr): add lighthouseMarker timeOrigin support #12688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Jun 24, 2021
demo.js
Outdated
| @@ -0,0 +1,40 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
We've added demo puppeteer scripts to a bunch of PRs now. At some point we should start converting our demos into smoke tests.
There was a problem hiding this comment.
I agree we should start thinking about our approach to more comprehensive integration tests as we expand audit cases 👍
At least in most of my cases though, that doesn't solve my problem since I need the CLI to support a --fraggle-rock mode, I just want to look through the report :) That's on the radar as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the lighthouse marker time origin support needed to activate the audits relying on
tracesin timespan mode. This doesn't actually enable any audits to run yet, but that next phase ballooned the PR a bit, so thought I would focus on time origin support first.Related Issues/PRs
ref #11313
ref #12595