cli(fr): add --fraggle-rock flag #12805
Conversation
| const fraggleRock = require('../lighthouse-core/fraggle-rock/api.js'); | ||
| const puppeteer = require('puppeteer'); | ||
| // @ts-expect-error - FIXME: lighthouse-logger is greedy and takes over `debug` for all packages | ||
| require('debug').enable('-puppeteer:*'); |
There was a problem hiding this comment.
Please pull up this require to reduce an extra complication when automating the conversion to ESM.
There was a problem hiding this comment.
Oh is that happening imminently? I don't want this line to exist for more than a week (PR already in progress to make it unnecessary)
If you're referring to puppeteer, I was hoping to avoid injecting puppeteer into the default dependencies for an experimental flag due to the extra postinstall hooks. const puppeteer = await import('puppeteer') should be OK, right?
There was a problem hiding this comment.
Oh is that happening imminently?
No, just a mechanical code review suggestion I have these days when I see require :)
const puppeteer = await import('puppeteer') should be OK, right?
Yeah
Summary
Happy to add whatever public caveats others think is wise to minimize accidental usage at this stage (currently just
[EXPERIMENTAL]on the CLI flag). Hopefully this gets us more internal usage, I know I'll be trying it out a bit more :) It's not at complete parity yet, but the basic default usage should be working at this point.Next steps:
lighthouse-loggerto avoid stomping on other packages debug misc: add prefix to lighthouse-logger debug scope #12806Related Issues/PRs
ref #11313