tests(fr): add fraggle rock smoke tests #12834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Jul 30, 2021
|
|
||
| - run: sudo apt-get install xvfb | ||
| - name: yarn smoke --fraggle-rock | ||
| run: xvfb-run --auto-servernum yarn smoke --debug --fraggle-rock -j=1 --retries=2 a11y lantern seo-passing seo-failing csp |
There was a problem hiding this comment.
I suppose the burndown in the inverse of this smoke list? It'd be nice to use --invert here and list just the tests that are failing (the ones we need to fix).
There was a problem hiding this comment.
I suppose the burndown in the inverse of this smoke list? It'd be nice to use --invert here and list just the tests that are failing (the ones we need to fix).
Great call, I'll do that when the list is a smidge shorter :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a fraggle rock mode to our smoke tests and enables a subset of them in CI. Now we have a clean burndown of many of our FR-COMPAT issues too :)
Related Issues/PRs
ref #11313