Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(flow): standalone shell report with preact #12850

Merged
merged 63 commits into from
Aug 18, 2021
Merged

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Aug 3, 2021

Basic shell for a FR flow report. It doesn't actually render the report, I'm hoping to use the updated renderer API for that part #12772.

In the meantime we can work on the flow UX items like the sidebar and summary page.

Example report: https://gist.github.com/adamraine/7bf5b5b3c8a3f08cbf1226cddaeff078

Ref #11313

@google-cla

This comment has been minimized.

@google-cla google-cla bot added the cla: no label Aug 3, 2021
@connorjclark
Copy link
Collaborator

connorjclark commented Aug 3, 2021

Can you add the result to lighthouse-core/scripts/build-report-for-autodeployment.js so we can easily preview it? Not much to see now I know, but might as well set it up for the near future.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had quite a hand in most of this, so I'm most interested in other folks feedback :)

but tsx sounds great to me!

report/report-generator.js Outdated Show resolved Hide resolved
types/lhr.d.ts Outdated Show resolved Hide resolved
Co-authored-by: Patrick Hulce <[email protected]>
@google-cla

This comment has been minimized.

build/build-report.js Outdated Show resolved Hide resolved
flow-report/standalone-flow.tsx Outdated Show resolved Hide resolved
flow-report/test/App-test.tsx Outdated Show resolved Hide resolved
flow-report/types/flow-report.d.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants