Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add --debugNavigation setting #12902

Merged
merged 5 commits into from
Aug 11, 2021
Merged

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Aug 10, 2021

Summary
Adds a setting that keeps the page open until continueLighthouseRun() is evaluated in the console before moving on to close gatherers so you explore the page and DevTools as long as necessary. One consequence of using this flag is that traces / network records are affected by whatever the user does, but the purpose is not to ever use the results of this run, simply to explore the page (in fact the smoketest asserts that this expands the trace window)

Related Issues/PRs
fixes #12641

@patrickhulce patrickhulce requested a review from a team as a code owner August 10, 2021 21:30
@patrickhulce patrickhulce requested review from connorjclark and removed request for a team August 10, 2021 21:30
@google-cla google-cla bot added the cla: yes label Aug 10, 2021
types/externs.d.ts Outdated Show resolved Hide resolved
Co-authored-by: Connor Clark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --debug flag to keep the loaded page open for inspection
3 participants