Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(build): do not include locales in devtools bundle #12921

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

connorjclark
Copy link
Collaborator

this also fixes brfs readFileTransform... readFileSyncTransform is not an option. Not sure how the PRs that I made introducing this recorded byte savings ... 😄

fixes #12919

@connorjclark connorjclark requested a review from a team as a code owner August 16, 2021 23:05
@connorjclark connorjclark requested review from patrickhulce and removed request for a team August 16, 2021 23:05
@google-cla google-cla bot added the cla: yes label Aug 16, 2021
@connorjclark connorjclark changed the title misc(build): do not include locales in dt bundle. misc(build): do not include locales in dt bundle Aug 16, 2021
@connorjclark connorjclark changed the title misc(build): do not include locales in dt bundle misc(build): do not include locales in devtools bundle Aug 16, 2021
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better :)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devtools bundle went form 1 MB -> 11 MB
3 participants