report(flow): summary page #12973
Merged
report(flow): summary page #12973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Aug 26, 2021
| className="SummaryFlowStep__screenshot" | ||
| data-testid="SummaryFlowStep__screenshot" | ||
| src={screenshot || undefined} | ||
| style={{width: THUMBNAIL_WIDTH, maxHeight: thumbnailHeight}} |
There was a problem hiding this comment.
just set the height explicitly and rely on object-fit?
There was a problem hiding this comment.
That cuts off part of the screenshot if it doesn't fit the aspect ratio of the emulated device screen. Navigation screenshots were this way before I switched to FPS.
Ultimately this is a bug with how the screenshots are collected, but I still think we should leave this as maxHeight in case they pop up again.
There was a problem hiding this comment.
Gotcha, do we have an issue or entry in #11313 to tackle the screenshot bug you mention?
| @@ -96,6 +96,7 @@ | |||
| "@firebase/auth-types": "0.3.2", | |||
| "@firebase/util": "0.2.1", | |||
| "@rollup/plugin-node-resolve": "^13.0.4", | |||
| "@rollup/plugin-typescript": "^2.1.0", | |||
There was a problem hiding this comment.
haha, sounds good, but let's work to find a better reason for the perf packet later ;)
This was referenced Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a bit messy, and I haven't started the tests yet. Wanted to get some initial thoughts on the structure / looks before I finish up.
Gaugeis an example of a component imported from the normal report renderer.