core(fr): force use of devtools throttling in timespan mode #13013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
force-pushed
the
fr_force_observed_timespan
branch
from
d494ccb
to
fe72d0d
Compare
patrickhulce
commented
Sep 7, 2021
| @@ -451,5 +462,4 @@ describe('Fraggle Rock Config', () => { | |||
| }); | |||
|
|
|||
| it.todo('should support plugins'); | |||
| it.todo('should adjust default pass options for throttling method'); | |||
There was a problem hiding this comment.
this was just missed as part of #12873
adamraine
approved these changes
Sep 7, 2021
This shouldn't affect either of those bullets we currently have there, but I agree we should encourage consistent settings within flow reports (and possibly add toplevel warnings if they don't match in critical ways) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevents audits from being marked as notApplicable/inconsistent when running in timespan mode by forcing use of devtools throttling and fixes our TBT audit to work in timespan mode.
I wrestled with the idea of a warning, but ultimately decided against it for this PR. The current flow of single-config means a warning would be printed every time, whether user action was required or not, or the logic for overrides is severed from the warning logic (overrides occur after resolution, warning would need to come before resolution to identify if it was manually specified as well as be default-config/preset aware, which expands the scope for what IMO, is a low value return).
If others feel strongly about the warning, happy to add to the burndown list for future.
Related Issues/PRs
ref #11313