Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(proto): add i18n.icuMessagePaths #13068

Merged
merged 1 commit into from
Sep 15, 2021
Merged

misc(proto): add i18n.icuMessagePaths #13068

merged 1 commit into from
Sep 15, 2021

Conversation

connorjclark
Copy link
Collaborator

Turns out we'll need to use swap locale in PSI.

ref: #10148

@connorjclark connorjclark requested a review from a team as a code owner September 15, 2021 20:43
@connorjclark connorjclark requested review from patrickhulce and removed request for a team September 15, 2021 20:43
@google-cla google-cla bot added the cla: yes label Sep 15, 2021
paulirish
paulirish approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the post-roundtrip JSON and according to jsoncompare, this field identical to the one in the orig samplev2 json.

also what a rude failure from GHA
image

@paulirish paulirish merged commit fa69d24 into master Sep 15, 2021
@paulirish paulirish deleted the messagepaths-proto branch September 15, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@patrickhulce patrickhulce Awaiting requested review from patrickhulce

Assignees

@patrickhulce patrickhulce

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @paulirish @patrickhulce @devtools-bot