core: update cdt SourceMap to latest devtools frontend #13095
Conversation
connorjclark
requested review from
adamraine
and removed request for
a team
| ...expressionsToRemove, | ||
| ...Object.values(rawCodeToReplace), | ||
| ...Object.keys(rawCodeToReplace), |
| // https://github.com/ChromeDevTools/devtools-frontend/blob/master/front_end/core/platform/array-utilities.ts#L125 | ||
|
|
||
| /** | ||
| * @param {any[]} array |
There was a problem hiding this comment.
not worth effort / possibly impossible to denote in jsdoc
| ; | ||
| ; | ||
| ; | ||
| ; |
There was a problem hiding this comment.
yeah there's some junk in here but i don't really mind.
| @@ -127,9 +127,9 @@ class UnusedJavascriptSummary { | |||
| let offset = lineOffsets[mapping.lineNumber]; | |||
|
|
|||
| offset += mapping.columnNumber; | |||
| const lastColumnOfMapping = | |||
| // @ts-expect-error: We will upstream lastColumnNumber to CDT eventually. | |||
| (mapping.lastColumnNumber - 1) || lineLengths[mapping.lineNumber]; | |||
There was a problem hiding this comment.
mapping.lastColumnNumber is sometimes undefined (for the last mapping of each line), and in that case this value falls back to the line length (acknowledgement: this is mixing data defined in the map and data from the script content).
arguably this should be calculated in computeLastGeneratedColumns, but 1) TextSourceMap doesn't know about the script content and 2) each mapping doesn't know how long of a range it covers, so there is no way to know what to set the lastColumnNumber of the last mapping on a line. All of this may mean upstreaming this property will never be feasible.
Should be no behavior changes. But possibly a bug fix or two. Test didn't change. see history: https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/core/sdk/SourceMap.ts;bpv=1
Recent-ish refactors to frontend allows us to delete the
Array.prototypehacking from ourSDK.js.